samueleresca commented on code in PR #391: URL: https://github.com/apache/pekko-persistence-jdbc/pull/391#discussion_r2572629700
########## core/src/main/resources/schema/oracle/oracle-number-boolean-schema-legacy-migration.sql: ########## @@ -0,0 +1,6 @@ +-- SPDX-License-Identifier: Apache-2.0 + +-- see https://github.com/apache/pekko-persistence-jdbc/pull/323 + +ALTER TABLE "journal" MODIFY "deleted" NUMBER(1) Review Comment: Same as the above, you will lose the `check (DELETED in (0, 1)),` defined [in the schema](https://github.com/apache/pekko-persistence-jdbc/pull/323/files#diff-eb12b9a78c740e9ec06729f67f89159b33164ebdb1cc42949daad14933d8e75fR6) ########## core/src/main/resources/schema/oracle/oracle-number-boolean-migration.sql: ########## @@ -0,0 +1,6 @@ +-- SPDX-License-Identifier: Apache-2.0 + +-- see https://github.com/apache/pekko-persistence-jdbc/pull/323 + +ALTER TABLE EVENT_JOURNAL MODIFY "deleted" NUMBER(1) Review Comment: Shouldn't this be `DELETED`? Also, by altering the column in the table, you lose all the checks [already present in the column](https://github.com/apache/pekko-persistence-jdbc/pull/323/files#diff-b43ed855a228bcb11465dc5b9ad2769e9a84db0f71d280928a1dd133a78efaf3R6) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
