timw commented on PR #940:
URL: https://github.com/apache/pekko-http/pull/940#issuecomment-3809589948
> This should target main branch, not 1.4.
>
> When it gets merged, we can consider backporting to 1.4.
Will rebase and re-push once you've had a chance for an initial comment.
> The code doesn't compile in Scala 2.12 and causes binary compatibility
issues for other Scala versions. This will be less of an issue in main branch
(no Scala 2.12 support, for example).
Looks like that was due to the import changes (I haven't got much 2.12
experience TBH, so that's a bit mysterious) - will tidy all that up and check.
Will also have a think about binary compatibility - that might be harder to
avoid if the concat API is to be available to the Java DSL, but it could be
shunted to a utility method. The javadsl/scaladsl split does make things a bit
suboptimal WRT sealing the types, so happy to take suggestions on the typical
idioms there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
