pjfanning commented on PR #1382: URL: https://github.com/apache/pekko-connectors/pull/1382#issuecomment-3813964771
I added a flag to get the Java compiler involved. So the build works locally and hopefully will in CI. The slight negative is that we will have stray com.google.protobuf classes in the connector jar. Ones that should hopefully match the protobuf-java versions pretty well but if someone used our published connector jar and tried to force the use of a different protobuf-java then the different versions of the same class could clash. One follow up change that we look at is trying to post process the connector jar to remove the unwanted com.google.protobuf classes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
