pjfanning opened a new issue, #944:
URL: https://github.com/apache/pekko-http/issues/944

   We removed the deprecated WebSocketUpgrade class in 2.0.0-M1.
   
   Play needs access to work at a low level and just the Message level that 
WebSocketUpgrade supports. 
(https://github.com/playframework/playframework/issues/13744)
   
   
https://github.com/apache/pekko-http/blob/75c2e9075c6538d6b32dd1c05431105e7b5ec3a5/http-core/src/main/scala/org/apache/pekko/http/impl/engine/ws/UpgradeToWebSocketLowLevel.scala#L43
   
   As you can see in UpgradeToWebSocketLowLevel, it should be easy enough 
expose FrameEvent support.
   
   I prefer this to adding back the WebSocketUpgrade code and supporting both 
approaches again.
   
   If we do change UpgradeToWebSocket support maybe we can hide the frame event 
support and have users cast their UpgradeToWebSocket instance to 
UpgradeToWebSocketLowLevel to access the additional handleFrameEvents method.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to