He-Pin opened a new pull request, #648:
URL: https://github.com/apache/pekko-grpc/pull/648
## Motivation
In the Scala 2.12 codegen module, `@nowarn("cat=unused-params")` was applied
per-site to silence a compiler warning about an unused parameter in
`registerExtensions`. This annotation approach is fragile — it must be
remembered at every call site and couples source files to specific warning
categories.
## Modification
- Removed the per-site `@nowarn` annotation from `CodeGenerator.scala`
(scala-2.12 version)
- Added a precise, scoped
`-Wconf:src=.*/grpc/gen/CodeGenerator\.scala:msg=is never used:silent` compiler
option to `project/Common.scala`, targeting only the specific file and message
pattern
## Result
The unused parameter warning is suppressed via compiler configuration
instead of per-site annotations. This is more maintainable, less intrusive, and
follows Scala compiler best practices.
Upstream reference: https://github.com/akka/akka-grpc/commit/46bd59ff
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
