pjfanning commented on code in PR #1494:
URL: https://github.com/apache/pekko-connectors/pull/1494#discussion_r2924679692
##########
google-cloud-pub-sub-grpc/src/main/scala/org/apache/pekko/stream/connectors/googlecloud/pubsub/grpc/PubSubSettings.scala:
##########
@@ -37,7 +32,8 @@ final class PubSubSettings private (
@deprecated(
"Use org.apache.pekko.stream.connectors.google.GoogleSettings",
"Alpakka 3.0.0") @Deprecated val callCredentials: Option[
- CallCredentials]) {
+ CallCredentials],
+ private[grpc] val useGoogleSettings: Boolean = true) {
Review Comment:
van you just add new constructors and leave the old ones as is?
##########
google-cloud-pub-sub-grpc/src/main/scala/org/apache/pekko/stream/connectors/googlecloud/pubsub/grpc/PubSubSettings.scala:
##########
@@ -37,7 +32,8 @@ final class PubSubSettings private (
@deprecated(
"Use org.apache.pekko.stream.connectors.google.GoogleSettings",
"Alpakka 3.0.0") @Deprecated val callCredentials: Option[
- CallCredentials]) {
+ CallCredentials],
+ private[grpc] val useGoogleSettings: Boolean = true) {
Review Comment:
can you just add new constructors and leave the old ones as is?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
