pjfanning commented on code in PR #1494: URL: https://github.com/apache/pekko-connectors/pull/1494#discussion_r2958760675
########## google-cloud-pub-sub-grpc/src/main/scala/org/apache/pekko/stream/connectors/googlecloud/pubsub/grpc/AckDeadlineDistribution.scala: ########## @@ -0,0 +1,230 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * license agreements; and to You under the Apache License, version 2.0: + * + * https://www.apache.org/licenses/LICENSE-2.0 Review Comment: why this header - did you take this file from Akka - why not the standard Apache license header? ########## google-cloud-pub-sub-grpc/k8s/GkeAuthTest.scala: ########## @@ -0,0 +1,79 @@ +/* Review Comment: use an org.apache.pekko prefix to the package name use the standard Apache license header unless you took this code from Akka can you explain this code generally? - it doesn't look like a test ########## google-common/src/main/scala/org/apache/pekko/stream/connectors/google/auth/GoogleApplicationDefaultCredentials.scala: ########## @@ -0,0 +1,47 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * license agreements; and to You under the Apache License, version 2.0: + * Review Comment: why this header - did you take this file from Akka - why not the standard Apache license header? Is it based on another file in this repo? - if so it needs all the headers including the Akka copyright. ########## google-cloud-pub-sub-grpc/src/main/scala/org/apache/pekko/stream/connectors/googlecloud/pubsub/grpc/FlowControl.scala: ########## @@ -0,0 +1,70 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * license agreements; and to You under the Apache License, version 2.0: + * Review Comment: why this header - did you take this file from Akka - why not the standard Apache license header? ########## google-cloud-pub-sub-grpc/k8s/Dockerfile: ########## @@ -0,0 +1,7 @@ +FROM eclipse-temurin:21-jre-alpine + Review Comment: add an Apache source license at start of file and make sure every file has and EOL at the end ########## google-cloud-pub-sub-grpc/k8s/application.conf: ########## @@ -0,0 +1,10 @@ +pekko { Review Comment: add a SPDX Apache license at start of file and make sure every file has and EOL at the end have a look at other conf files in this repo for the SPDX header ########## google-cloud-pub-sub-grpc/k8s/build-and-push.sh: ########## @@ -0,0 +1,73 @@ +#!/bin/bash Review Comment: add an Apache source license at start of file and make sure every file has and EOL at the end ########## google-cloud-pub-sub-grpc/k8s/gke-auth-test-job.yaml: ########## @@ -0,0 +1,27 @@ +apiVersion: batch/v1 Review Comment: add an Apache source license at start of file and make sure every file has and EOL at the end ########## google-common/src/test/scala/org/apache/pekko/stream/connectors/google/auth/ProvidedCredentialsSpec.scala: ########## @@ -0,0 +1,49 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * license agreements; and to You under the Apache License, version 2.0: + * + * https://www.apache.org/licenses/LICENSE-2.0 Review Comment: why this header - did you take this file from Akka - why not the standard Apache license header? ########## google-common/src/test/scala/org/apache/pekko/stream/connectors/google/auth/CredentialsSpec.scala: ########## @@ -0,0 +1,151 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * license agreements; and to You under the Apache License, version 2.0: + * + * https://www.apache.org/licenses/LICENSE-2.0 + * Review Comment: why this header - did you take this file from Akka - why not the standard Apache license header? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
