ribafish opened a new pull request, #661:
URL: https://github.com/apache/pekko-grpc/pull/661

   ## Problem
   
   The `logfile_enc` option passed to the pekko-grpc protoc plugin contains an 
absolute path (`project.buildDir`), which the `protobuf-gradle-plugin` 
registers as a task input for `GenerateProtoTask`. This breaks Gradle build 
cache relocatability: builds of the same commit from different checkout 
directories produce different cache keys, causing unnecessary cache misses.
   
   Closes #660
   
   ## Fix
   
   Use a path relative to the project directory instead of an absolute path. 
The protoc plugin process runs with the project directory as its working 
directory, so the relative path (`build/pekko-grpc-gradle-plugin.log`) resolves 
to the same file.
   
   The absolute `Path` used by `printProtocLogs` is unchanged — only the string 
passed as a protoc plugin option is affected.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to