pjfanning commented on PR #708: URL: https://github.com/apache/pekko-management/pull/708#issuecomment-4097864008
> I have some remarks, mainly on the tests. Apart from that I think it should work. On my part, I think the configuration i will recommend is to have the `on-truncate-add-hash-length` to the exact value of the hash representation (so 52) to have the full range to avoid collisions, but keeping it as a choice just offers more possibilities to users. 8 char hash gives a very low possibility that you can have a clash with a real world number of leases. I guess if you have millions or billions of leases then the risks increase. The configs are there and people can set 253 and 52 for the 2 values which are probably not bad settings - meaning that the lease names should be pretty readable while clashes are very unlikely. Even 63 and 8 mean that the lease names should be pretty readable with a low risk of a clash. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
