drse commented on issue #2831:
URL: https://github.com/apache/pekko/issues/2831#issuecomment-4187629775

   > [@drse](https://github.com/drse) what is wrong with the japi package 
classes? 
https://github.com/apache/pekko/tree/main/persistence-tck/src/main/scala/org/apache/pekko/persistence/japi
   
   Ah, sorry, didn't notice the japi extensions, will use those.
   
   > Where does Pekko Persistence define an oversized message?
   
   I don't think Pekko Persistence defines that. Perhaps the message size 
shouldn't be a concern of this layer, that's the underlying store's problem. 
I'm using NATS as a backend for the journal and durable state store, and NATS 
imposes a limit on messages size, which breaks persistence, but this doesn't 
really show up with the default jdbc implementation. My thought is that since 
the TCK is meant to test broader compatibility, perhaps the TCK itself should 
have a concept of an oversized message, maybe something artificial like 
1/10/100MB binary payload.
   
   > It is worthwhile to add tests where the durable state save attempt is not 
for the latest sequence number (OCC testing) and roundtrip tests probably make 
sense.
   
   Agree.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to