pjfanning commented on PR #2847: URL: https://github.com/apache/pekko/pull/2847#issuecomment-4191456640
@copilot ByteStringParser needs its readShort to be an int return value. Is there a good reason to have SWARUtil support this as well as readShort as a short and accessing this via a new package private unchecked read method in ByteString? Don't add this unless there is a reasonable performance reason to support it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
