pjfanning opened a new pull request, #2940: URL: https://github.com/apache/pekko/pull/2940
retry test and improve contact robustness Motivation: The `must rebuild the SSLContext using new keys` test is flaky because `contact` times out (6s) while TLS connection establishment is still in progress. A single failed run discards all the work done in that attempt. Modification: - `contact` now retries the `Identify`/`ActorIdentity` exchange up to 3 times (3 s each) rather than failing immediately on one timeout, giving TLS connection establishment additional time to complete. - `RotatingProviderWithChangingKeysSpec` overrides `withFixture` to retry the whole test once on failure. Before retrying, actor systems created during the failed attempt are terminated so they do not interfere with the second run (no port conflicts since new systems obtain fresh dynamic ports; systems are also tracked in ArteryMultiNodeSpec.remoteSystems for final cleanup in afterTermination). - Added `import scala.concurrent.duration._` required by `3.seconds`. Result: The test is more resilient to transient TLS handshake delays and is automatically retried once if it still fails. Tests: - scalafmt not installed; sbt not installed; recorded as skipped - sbt "remote / Test / testOnly o.a.p.remote.artery.tcp.ssl.RotatingProviderWithChangingKeysSpec" - skipped (sbt unavailable) References: None - reduces test flakiness Agent-Logs-Url: https://github.com/pjfanning/incubator-pekko/sessions/080d49a3-0c3c-401b-ae0a-a5fe875189cc -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
