ptrdom commented on PR #465: URL: https://github.com/apache/pekko-projection/pull/465#issuecomment-4390304377
I am not sure about these test - they basically just load the default plugin config and pass it as a parameter, so essentially you could revert the whole feature implementation besides the interface change, run these tests and they would still pass. It would be better to make the config slightly different from default, so then it would be clear that the config that was passed as a parameter was used and not the default config. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
