He-Pin commented on PR #2924: URL: https://github.com/apache/pekko/pull/2924#issuecomment-4393986342
Merged current main into this branch in e6e9f567f4 and resolved the two conflicts: - MetricsBasedResizerSpec: kept the second async send stabilization and retained main's awaitAssert guard before recording the performance log. - ByteStringSpec: kept the ByteString2 serialization coverage and main's SerializationProxy round-trip coverage. - Also removed one trailing whitespace issue from the merged ClusterShardingCoordinatorRoleSpec so diff checks stay clean. On the design concern: I left the ByteString2 implementation in place for this draft because the simpler copy-to-compact fast path would trade the Vector allocation for copying payload bytes on header+payload appends. The current approach keeps that use case zero-copy while promoting to ByteStrings as soon as a third fragment is added. If the preferred direction is to keep ByteString smaller and accept the copy for two-fragment appends, I can rework the PR that way. Local verification passed: - sbt "actor-tests / Test / testOnly org.apache.pekko.util.ByteStringSpec org.apache.pekko.routing.MetricsBasedResizerSpec" - sbt "actor-tests / Test / testOnly org.apache.pekko.serialization.PrimitivesSerializationSpec org.apache.pekko.serialization.ReferenceSerializationSpec org.apache.pekko.serialization.AllowJavaSerializationSpec" - sbt "bench-jmh / Compile / compile" - sbt "actor-tests / Test / scalafmt" "actor / Compile / scalafmt" "bench-jmh / Compile / scalafmt" - git diff --check - git diff --cached --check All review threads are currently resolved. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
