pjfanning opened a new pull request, #365:
URL: https://github.com/apache/pekko-persistence-r2dbc/pull/365

   `OverflowStrategy.dropNew` was deprecated in Akka 2.6.11, carried into Pekko 
1.x as deprecated, and removed in Pekko 2.0.x — making this a 
forward-compatibility blocker.
   
   ## Change
   
   - **`R2dbcReadJournal.scala`**: Replace `OverflowStrategy.dropNew` with 
`OverflowStrategy.dropHead` in the pub/sub `Source.actorRef` buffer 
configuration.
   
   ```scala
   // Before (deprecated)
   overflowStrategy = OverflowStrategy.dropNew
   
   // After
   overflowStrategy = OverflowStrategy.dropHead
   ```
   
   `dropHead` (evict oldest buffered element) is semantically appropriate here: 
the pub/sub source is merged with a DB source, so any element lost from the 
buffer — whether dropped on arrival (`dropNew`) or evicted when stale 
(`dropHead`) — is recovered by the DB source. The `deduplicate` stage 
downstream handles events delivered via both paths.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to