pjfanning commented on code in PR #376:
URL:
https://github.com/apache/pekko-persistence-r2dbc/pull/376#discussion_r3247610927
##########
projection/src/main/scala/org/apache/pekko/projection/r2dbc/internal/R2dbcProjectionImpl.scala:
##########
@@ -512,8 +532,12 @@ private[projection] class R2dbcProjectionImpl[Offset,
Envelope](
offsetStore.readOffset()
// Called from InternalProjectionState.saveOffsetAndReport
- override def saveOffset(projectionId: ProjectionId, offset: Offset):
Future[Done] =
- offsetStore.saveOffset(offset)
+ override def saveOffset(projectionId: ProjectionId, offset: Offset):
Future[Done] = {
+ // need the envelope to be able to call offsetStore.saveOffset
+ // FIXME maybe we can cleanup this mess when moving R2dbcProjection to
the Pekko Projections repository?
+ throw new IllegalStateException(
Review Comment:
this is directly from the akka-persistence-r2dbc code although Copilot
changed the comment to say pekko
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
