pjfanning commented on code in PR #702:
URL: https://github.com/apache/pekko-grpc/pull/702#discussion_r3260151851
##########
docs/src/main/paradox/server/walkthrough.md:
##########
@@ -240,15 +240,15 @@ There are two recommended ways to deal with this:
This is an example based on the Hello World above, but allowing users to
change the greeting through a unary call:
Scala
-: @@snip
[GreeterServiceImpl.scala](/plugin-tester-scala/src/main/scala/example/myapp/statefulhelloworld/GreeterServiceImpl.scala)
{ #stateful-service }
+: @@snip
[GreeterServiceImpl.scala](/plugin-tester-scala/src/main/scala/example/myapp/typedhelloworld/GreeterServiceImpl.scala)
{ #stateful-service }
Review Comment:
Could you revert these changes and add new paragraphs that linked to the
typed version?
##########
docs/src/main/paradox/server/walkthrough.md:
##########
@@ -240,15 +240,15 @@ There are two recommended ways to deal with this:
This is an example based on the Hello World above, but allowing users to
change the greeting through a unary call:
Scala
-: @@snip
[GreeterServiceImpl.scala](/plugin-tester-scala/src/main/scala/example/myapp/statefulhelloworld/GreeterServiceImpl.scala)
{ #stateful-service }
+: @@snip
[GreeterServiceImpl.scala](/plugin-tester-scala/src/main/scala/example/myapp/typedhelloworld/GreeterServiceImpl.scala)
{ #stateful-service }
Review Comment:
Could you revert these changes and add new paragraphs that link to the typed
version?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
