He-Pin opened a new pull request, #3005:
URL: https://github.com/apache/pekko/pull/3005
### Motivation
`FlattenTest` and `FilePublisherTest` abort the TCK suite on JDK 25 nightly
runs with:
```
[WARN] CoordinatedShutdown(pekko://FlattenTest) Coordinated shutdown phase
[actor-system-terminate] timed out after 10000 milliseconds
java.lang.RuntimeException: Failed to stop [FlattenTest] within [40000
milliseconds]
toDie:
Actor[pekko://FlattenTest/system/Materializers/StreamSupervisor-4/flow-6-0-flattenMerge#-2133714097]
at
org.apache.pekko.stream.tck.ActorSystemLifecycle.shutdownActorSystem(ActorSystemLifecycle.scala:61)
```
The outer 40s shutdown await scales with `pekko.test.timefactor` (via
`Timeouts.actorSystemShutdownTimeoutMillis`), but the inner
`CoordinatedShutdown` `actor-system-terminate` phase keeps its default `10s`,
which is occasionally too tight on JDK 25 nightlies where virtualized
dispatchers + heavy stochastic TCK iterations leave a stream actor
mid-shutdown. The phase times out before the last flow actor finishes
terminating, even though the outer await still has 30s of headroom.
### Modification
- `ActorSystemLifecycle` now layers a baseline config under
`additionalConfig`, widening the `actor-system-terminate` phase timeout from
`10s` to `30s` for every TCK `ActorSystem` (Publisher, Subscriber, and
IdentityProcessor verifications).
- The baseline is applied via `withFallback` so any subclass
`additionalConfig` override that explicitly sets the same key still wins.
### Result
The inner phase now has 30s to drain leftover materializations before the
outer 40s await fires (`timeFactor=4` on JDK 25 nightly), removing the abort
path observed for `FlattenTest` and `FilePublisherTest` without changing
behaviour on local runs (where shutdown completes well under 1s).
### Tests
- `sbt stream-tests-tck/Test/compile` (Scala 2.13) succeeded locally.
### References
- Failing nightly: https://github.com/apache/pekko/actions/runs/26611472055
- Tracking issue: #2573
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
