He-Pin opened a new pull request, #3012:
URL: https://github.com/apache/pekko/pull/3012

   ## Motivation
   
   `HandshakeRetrySpec` *"be retried during handshake-timeout (no message 
loss)"* is intermittently flaky in CI, timing out at `expectMsg` while waiting 
for `"hello"` (#560, #634, #276).
   
   The first message is sent **before** `systemB` exists, so it is buffered 
while the outbound handshake is retried, and is only delivered once the 
handshake completes. With `handshake-timeout = 10s`, delivery can legitimately 
take longer than the default expect timeout (`single-expect-default`, ~6s under 
`timefactor = 2` in CI), so the assertion fires before the message arrives — 
even though no message is actually lost.
   
   ## Modification
   
   Wait for the buffered `"hello"` with an explicit `15s` timeout (dilated by 
`pekko.test.timefactor`), comfortably above the `10s` `handshake-timeout`.
   
   ## Result
   
   The test no longer races the handshake window under CI load; it still passes 
locally.
   
   ```
   [info] HandshakeRetrySpec:
   [info] - must be retried during handshake-timeout (no message loss) (1 
second, 241 milliseconds)
   [info] All tests passed.
   ```
   
   ## Tests
   
   `remote/testOnly org.apache.pekko.remote.artery.HandshakeRetrySpec` — 
passes. `scalafmt` run on the changed file. Test-only change.
   
   ## References
   
   Fixes #560
   Fixes #634
   Fixes #276


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to