pjfanning commented on code in PR #713:
URL: https://github.com/apache/pekko-grpc/pull/713#discussion_r3327105376
##########
codegen/src/main/scala/org/apache/pekko/grpc/gen/Main.scala:
##########
@@ -16,12 +16,15 @@ package org.apache.pekko.grpc.gen
import java.io.ByteArrayOutputStream
import java.net.URLDecoder
+import scala.annotation.nowarn
+
import com.google.protobuf.compiler.PluginProtos.CodeGeneratorRequest
import org.apache.pekko
import pekko.grpc.gen.javadsl.{ JavaClientCodeGenerator,
JavaInterfaceCodeGenerator, JavaServerCodeGenerator }
import pekko.grpc.gen.scaladsl.{ ScalaClientCodeGenerator,
ScalaServerCodeGenerator, ScalaTraitCodeGenerator }
// This is the protoc plugin that the gradle plugin uses
+@nowarn("msg=deprecated")
Review Comment:
this code needs to compile with Scala 3.8 now (sbt 2 plugins needs Scala
3.8+)
but also needs to compile in Scala 2.12
code compiles in Scala 3.8 but 'extends App' is now deprecated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
