The GitHub Actions job "Scalafmt" on pekko.git/feature/artery-frequency-sketch 
has failed.
Run started by GitHub user He-Pin (triggered by He-Pin).

Head commit for run:
83cd9ae3a6523e9abdafcbd0de3915bd99e7abae / He-Pin <[email protected]>
fix: address review feedback - keep CountMinSketch and make configurable

Motivation:
Reviewer (pjfanning) requested keeping the original CountMinSketch code
and making the compression scheme configurable so users can choose.

Modification:
- Restored CountMinSketch.java (was deleted in previous commit)
- Restored legal files for CountMinSketch attribution
- Added configuration option  to choose
  between 'count-min-sketch' and 'fast-frequency-sketch' (default)
- Created FrequencySketch abstraction trait with wrappers for both
  CountMinSketch and FastFrequencySketch
- Reverted CountMinSketchBenchmark to use CountMinSketch directly
  (FastFrequencySketch is private[pekko] and not accessible from bench-jmh)
- Removed MiMa filter since CountMinSketch is no longer removed

Result:
Users can now choose between CountMinSketch (legacy, ~128KB per connection)
and FastFrequencySketch (default, ~4KB per connection with TinyLFU aging).

Tests:
- remote/testOnly ...HeavyHittersSpec: 13/13 passed
- remote/testOnly ...CompressionTableSpec: 3/3 passed
- remote/compile: passed
- bench-jmh/compile: passed
- remote/mimaReportBinaryIssues: passed

Refs: #3023

Report URL: https://github.com/apache/pekko/actions/runs/26722653773

With regards,
GitHub Actions via GitBox


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to