pjfanning commented on code in PR #723:
URL: https://github.com/apache/pekko-grpc/pull/723#discussion_r3407920377
##########
project/Common.scala:
##########
@@ -60,7 +60,8 @@ object Common extends AutoPlugin {
"-Werror",
"-Wunused:imports",
"-encoding",
- "UTF-8")),
+ "UTF-8") ++
+ (if (scalaVersion.value.startsWith("3.3")) Seq("-Yfuture-lazy-vals")
else Seq.empty)),
Review Comment:
why not just include this in the Seq starting on line 48?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]