The GitHub Actions job "Pull Requests" on pekko.git/scala3-upgrade-fix-warnings has failed. Run started by GitHub user He-Pin (triggered by He-Pin).
Head commit for run: 462dff8067fa80f1820702805aab58ebf8a90638 / He-Pin <[email protected]> fix: fix Scala 3.8.4 compilation compatibility while preserving 3.3.x cross-build Motivation: The codebase needs to compile with both Scala 3.3.x (current production) and Scala 3.8.4 (forward compatibility for upcoming 3.9 LTS). Several patterns valid in 3.3.x are errors or warnings in 3.8.4. Modification: - Merge PersistencePlugin [T: ClassTag] context bound and (implicit ev: PluginProvider) into a single implicit parameter list so subclasses can pass both arguments without the `using` keyword (cross-compatible with Scala 2.13 and 3.3.x) - Replace explicit ClassTag passing `method(arg)(ClassTag(clazz))` with `implicit val ct = ClassTag(clazz); method(arg)` pattern throughout the codebase (context bounds become `using` clauses in Scala 3.8, making positional passing an error) - Fix SortedSet.empty(ordering) / TreeSet.empty(ordering) across cluster, cluster-tools, cluster-sharding, distributed-data modules by binding the Ordering as an implicit val before calling .empty[Member] - Add @unchecked to type-test patterns that cannot be checked at runtime (Reachability.scala, AskPattern.scala) - Fix `_` wildcard type argument to `?` in scala-3-only source files - Fix LogSource resolution in MultiNodeSpec (classOf instead of this.getClass) - Fix "pure expression does nothing" in FixedBufferSpec structural type calls - Remove discarded non-Unit value (unused Success) in SnapshotStorage - Add -Wconf suppression rules for Scala 3.8 deprecation and syntax warnings in PekkoDisciplinePlugin (both main and test scopes) Result: All modules compile successfully with both Scala 2.13.18 and Scala 3.8.4. Cross-compilation with Scala 2.13 is preserved. No `using` keyword is used in shared source files. Tests: - sbt "++3.8.4" "Test / compile" — success - sbt "Test / compile" (2.13) — success (docs module has pre-existing unused warnings) References: None - proactive Scala 3.8 forward compatibility Report URL: https://github.com/apache/pekko/actions/runs/27475090222 With regards, GitHub Actions via GitBox --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
