ptrdom commented on code in PR #407:
URL:
https://github.com/apache/pekko-persistence-r2dbc/pull/407#discussion_r3414579331
##########
docker/docker-compose-postgres.yml:
##########
@@ -7,3 +7,9 @@ services:
environment:
POSTGRES_USER: postgres
POSTGRES_PASSWORD: postgres
+ healthcheck:
+ test: ["CMD", "pg_isready", "-U", "postgres", "-h", "127.0.0.1"]
+ interval: 5s
+ timeout: 10s
+ retries: 12
+ start_period: 10s
Review Comment:
I understand, but this code here is purely redundant - `SELECT 1` checks in
CI scripts check a broader scope of database capabilities. It does not hurt to
have it, but anyone who is not aware would not outright know this and would be
incorrectly lead to think that this code is somehow required. We can keep it, I
just wanted to clarify that my comment was not about beauty.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
