He-Pin commented on code in PR #409:
URL:
https://github.com/apache/pekko-persistence-r2dbc/pull/409#discussion_r3420312954
##########
docs/src/test/java/jdocs/home/state/BlogPost.java:
##########
@@ -23,9 +23,7 @@
import org.apache.pekko.persistence.typed.state.javadsl.DurableStateBehavior;
import org.apache.pekko.persistence.typed.state.javadsl.Effect;
-public class BlogPost
- extends DurableStateBehavior<
- BlogPost.Command, BlogPost.State> {
Review Comment:
Addressed. All formatting changes have been removed. The PR now only
contains compiler warning fixes in build.sbt, CommonSettings.scala, and one
deprecation fix in R2dbcDurableStateStore.scala.
##########
project/CommonSettings.scala:
##########
@@ -27,8 +27,11 @@ object CommonSettings extends AutoPlugin {
// Setting javac options in common allows IntelliJ IDEA to import them
automatically
Compile / javacOptions ++= Seq("-encoding", "UTF-8", "--release", "17"),
scalacOptions ++= {
+ val commonWconf = Seq(
+ // r2dbc-spi annotation parsing warning - external dependency, cannot
be fixed
+ "-Wconf:msg=could not find MAYBE in enum:s")
if (scalaBinaryVersion.value == "3")
- Seq(
+ commonWconf ++ Seq(
Review Comment:
Addressed. Removed the ConnectionFactoryProvider.scala change and all Java
formatting changes. The PR now only modifies build.sbt, CommonSettings.scala
(with `-language:existentials` and `-Wconf`), and one deprecation fix in
R2dbcDurableStateStore.scala.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
