pjfanning commented on code in PR #839: URL: https://github.com/apache/pekko-management/pull/839#discussion_r3435414459
########## rolling-update-kubernetes/src/main/scala/org/apache/pekko/rollingupdate/kubernetes/PodDeletionCostAnnotator.scala: ########## @@ -67,7 +67,8 @@ import com.typesafe.config.Config Cluster(context.system).subscribe(context.self, classOf[ClusterEvent.MemberUp], classOf[ClusterEvent.MemberRemoved]) - def receive: Receive = idle(0, SortedSet.empty(Member.ageOrdering), 0) + implicit val memberAgeOrdering: Ordering[Member] = Member.ageOrdering Review Comment: can you make the implicits private? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
