Philippus commented on code in PR #1696:
URL: https://github.com/apache/pekko-connectors/pull/1696#discussion_r3439092435
##########
sqs/src/test/scala/org/apache/pekko/stream/connectors/sqs/scaladsl/MessageAttributeNameSpec.scala:
##########
@@ -37,9 +37,9 @@ class MessageAttributeNameSpec extends AnyFlatSpec with
Matchers with LogCapturi
it should "reject names which are longer than 256 characters" in {
a[IllegalArgumentException] should be thrownBy {
MessageAttributeName(
-
"A.really.realy.long.attribute.name.that.is.longer.than.what.is.allowed.256.characters.are.allowed."
+
-
"however.they.cannot.contain.anything.other.than.alphanumerics.hypens.underscores.and.periods.though"
+
-
"you.cant.have.more.than.one.consecutive.period.they.are.also.case.sensitive")
+
"A.really.really.long.attribute.name.that.is.longer.than.what.is.allowed.256.characters.are.allowed."
+
+
"however.they.cannot.contain.anything.other.than.alphanumerics.hyphens.underscores.and.periods.though"
+
+
"you.can't.have.more.than.one.consecutive.period.they.are.also.case.sensitive")
Review Comment:
```suggestion
"you.cannot.have.more.than.one.consecutive.period.they.are.also.case.sensitive")
```
Using `'` is not allowed, so this test will fail the first requirement in
the `MessageAttributeName` class, while this test is about the third
requirement (length <= 256). Would be nice to add a separate "reject illegal
characters" test case though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
