He-Pin commented on code in PR #3086:
URL: https://github.com/apache/pekko/pull/3086#discussion_r3439203589
##########
actor-typed/src/main/scala/org/apache/pekko/actor/typed/internal/adapter/ActorAdapter.scala:
##########
@@ -100,7 +100,11 @@ import pekko.util.OptionVal
} else Terminated(ActorRefAdapter(ref))
handleSignal(msg)
case classic.ReceiveTimeout =>
- handleMessage(ctx.receiveTimeoutMsg)
+ // cancelReceiveTimeout() sets receiveTimeoutMsg to null, but a
classic ReceiveTimeout
+ // that was already enqueued in the mailbox before the cancel cannot
be retracted.
+ // Discard the stale timeout to avoid passing null into the typed
behavior stack (#3084).
+ val timeoutMsg = ctx.receiveTimeoutMsg
+ if (timeoutMsg != null) handleMessage(timeoutMsg)
Review Comment:
should use `ne`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
