pjfanning commented on code in PR #3085:
URL: https://github.com/apache/pekko/pull/3085#discussion_r3439501143
##########
actor-testkit-typed/src/test/java/jdocs/org/apache/pekko/actor/testkit/typed/javadsl/SyncTestingExampleTest.java:
##########
@@ -321,7 +263,8 @@ public void testSupportContextualAsk() {
// The response adaptation can be tested as many times as you want without
completing the ask
Hello.Command response1 = effect.adaptResponse(new Hello.Answer("No. Who
are you?"));
- assertEquals("No. Who are you?", ((Hello.GotAnAnswer) response1).answer);
+ assertTrue(response1 instanceof Hello.GotAnAnswer);
+ assertEquals("No. Who are you?", ((Hello.GotAnAnswer)
response1).answer());
// ... as can the message sent on a timeout
assertTrue(effect.adaptTimeout() instanceof Hello.NoAnswerFrom);
Review Comment:
can you change to assertInstanceOf as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
