The GitHub Actions job "Pull Requests" on 
pekko.git/refactor/java17-modernization-test-examples has failed.
Run started by GitHub user pjfanning (triggered by pjfanning).

Head commit for run:
506a6f18c55f81ee0d78d80021f6afb0570a0a1c / 虎鸣 <[email protected]>
fix: use assertInstanceOf per CR review feedback

Motivation:
CR reviewer suggested using JUnit's assertInstanceOf instead of
assertTrue + instanceof + cast pattern.

Modification:
- Replace assertTrue(response1 instanceof ...) + cast with
  assertInstanceOf(Hello.GotAnAnswer.class, response1)
- Replace assertTrue(effect.adaptTimeout() instanceof ...) with
  assertInstanceOf(Hello.NoAnswerFrom.class, effect.adaptTimeout())
- Add assertInstanceOf static import

Result:
Cleaner test assertions per CR review feedback.

Tests:
sbt "actor-testkit-typed / Test / compile" (success)
sbt javafmtAll (passes)

References:
Refs apache/pekko#3085

Report URL: https://github.com/apache/pekko/actions/runs/27815412216

With regards,
GitHub Actions via GitBox


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to