The GitHub Actions job "Pull Requests" on pekko.git/revert/broadcast-hub-longmap-3063 has failed. Run started by GitHub user He-Pin (triggered by He-Pin).
Head commit for run: 203f8081f069eda71d8e449aa2407f0db30c4aab / 虎鸣 <[email protected]> Revert "perf: replace ArrayList consumer wheel with LongMap for O(1) keyed removal (#3063)" Motivation: PR #3063 was inspired by akkadotnet/akka.net#8264. Although the Pekko implementation was written independently (using scala.collection.mutable .LongMap instead of Dictionary/HashMap), there is concern that the original idea and design framing came from reading the akka.net PR description rather than being derived independently from the Pekko codebase. Until the licensing and provenance question is resolved, revert the change so it can be re-done cleanly from scratch. Modification: Revert commit 28d61c5368 ("perf: replace ArrayList consumer wheel with LongMap for O(1) keyed removal (#3063)"). The consumer wheel returns from Array[LongMap[Consumer]] back to Array[java.util.ArrayList[Consumer]] with ArrayList.removeIf for keyed lookup. BroadcastHubBenchRunner and the high-consumer HubSpec tests added by that PR are removed; the JMH benchmark is restored to its prior configuration. Result: BroadcastHub behavior returns to its state before #3063. No public API or binary compatibility change vs. the current main branch; only the internal LongMap-based wheel introduced by #3063 is undone. Tests: - sbt "stream/compile" -> success - sbt "stream-tests/Test/testOnly *HubSpec" -> 48 passed, 0 failed - sbt "stream/mimaReportBinaryIssues" -> no issues - git diff --check origin/main..HEAD -> clean References: Refs #3063, Refs akkadotnet/akka.net#8264 - provenance review pending Report URL: https://github.com/apache/pekko/actions/runs/27873214570 With regards, GitHub Actions via GitBox --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
