raboof opened a new pull request, #746: URL: https://github.com/apache/pekko-grpc/pull/746
Towards #345 I observed the directory with the proto's was part of the `unmanagedResourceDirectories`. That might explain why they weren't included consistently: 'unmanaged' directories are for files that are expected to 'just exist' on disk, to there's no guard to make sure sbt reads that directory after it's been populated. This seemed to be caused by some code added in https://github.com/akka/akka-grpc/pull/149/changes which is intended to cover a fringe use case that probably doesn't really exist anymore, has this problem, and makes things complicated. This PRs simplifies things and makes sure the external proto directory is part of the managed classpath - but testing with `google-cloud-pub-sub-grpc` it seems to actually consistently _not_ generate the classes :laughing: . More detective work needed. This perhaps begs the question: are we sure we *want* to include the proto's in the artifacts? The generated API's should be fully usable just by the generated code, right? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
