He-Pin commented on issue #3132: URL: https://github.com/apache/pekko/issues/3132#issuecomment-4771328818
Closing as premature optimization. The proposed cache adds implementation complexity (bounded eviction, invalidation on topic pruning) without demonstrated benefit. `URLEncoder.encode` on short topic names and `ActorPath.toStringWithoutAddress` are not expensive operations — the GC pressure from a few string allocations per message is likely negligible compared to actor message dispatch, serialization, and network I/O costs. If this optimization is worth pursuing, please reopen with: - A JMH benchmark showing measurable throughput improvement (before vs. after) on a realistic high-throughput pub/sub workload - Evidence that the encoding/key-construction overhead is a meaningful fraction of total per-message cost -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
