pjfanning commented on code in PR #3137:
URL: https://github.com/apache/pekko/pull/3137#discussion_r3458180338
##########
actor/src/main/scala/org/apache/pekko/pattern/FutureTimeoutSupport.scala:
##########
@@ -134,23 +134,18 @@ trait FutureTimeoutSupport {
catch {
case NonFatal(t) => CompletableFuture.failedStage(t)
}
- if (stage.toCompletableFuture.isDone) {
- stage
- } else {
- val p = new CompletableFuture[T]
- val timeout = using.scheduleOnce(duration,
- () => {
- p.completeExceptionally(new TimeoutException(s"Timeout of $duration
expired"))
- stage.toCompletableFuture.cancel(true)
- ()
- })
- stage.handle[Unit]((v: T, ex: Throwable) => {
- timeout.cancel()
- if (v != null) p.complete(v)
- if (ex ne null) p.completeExceptionally(ex)
+ val millis = if (duration.isZero || duration.isNegative) 0L else
duration.toMillis
+ val timeoutMessage = s"Timeout of $duration expired"
Review Comment:
this line to create timeoutMessage should be moved to the `case _:
TimeoutException` match below.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
