pjfanning commented on PR #851: URL: https://github.com/apache/pekko-management/pull/851#issuecomment-4781941751
> compile the regex? For me, the lowercasing is a bug issue. The code can behave differently in different countries (locales). The compiled regex is a micro-optimisation and there are at least 6 separate replaceAlls in this module and I don't think anything is a hotpath. And the code is just simpler to maintain as is. I raised #852 for discussion. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
