He-Pin opened a new pull request, #3173: URL: https://github.com/apache/pekko/pull/3173
### Motivation Classic remoting ACKs forwarded by EndpointReader were not tied to the reader UID, so a delayed ACK from an old reader could affect the resend buffer after a new UID was confirmed. ### Modification Tag decoded ACKs with the EndpointReader UID and have ReliableDeliverySupervisor only process ACKs from the currently confirmed UID. Add a deterministic supervisor-level regression test covering stale and current reader ACKs. This keeps the regression focused on the actor/UID contract rather than relying on multi-node timing races. ### Result Stale reader ACKs are ignored while current-reader ACKs still acknowledge the active resend buffer. ### Tests - sbt "remote / Test / testOnly org.apache.pekko.remote.ReliableDeliverySupervisorSpec" - sbt headerCreateAll - sbt +headerCheckAll - scalafmt --mode diff-ref=origin/main - scalafmt --list --mode diff-ref=origin/main - git diff --check - qodercli -p --output-format stream-json --attachment /tmp/pekko-3160-qoder-review.diff (No must-fix findings) - sbt sortImports (failed: scalafix/scala.meta NoSuchMethodError in stream-tests and multi-node-testkit) ### References Fixes #3160 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
