The GitHub Actions job "Nightly Aeron Tests" on pekko.git/main has failed. Run started by GitHub user jrudolph (triggered by jrudolph).
Head commit for run: 07a346cc4bb7277cde2256426b6bb012664be4cf / He-Pin(kerr) <[email protected]> fix: validate full UniqueAddress in Artery system message ACK/NACK handling (#3175) Motivation: SystemMessageDelivery.notify() only compared the Address portion of incoming ACK/NACK messages, ignoring the UID. When a remote node restarts and obtains a new UID, a delayed ACK from the previous incarnation (same address, different UID) could pass the check and incorrectly clear the unacknowledged buffer, causing system messages to be silently dropped. Modification: Add isFromCurrentRemote() helper that checks the full UniqueAddress (address + UID) against the association's known uniqueRemoteAddress. Falls back to address-only matching when uniqueRemoteAddress is not yet established (pre-handshake), preserving existing behavior. Result: Stale ACKs from previous remote incarnations are rejected, preventing incorrect removal of system messages from the resend buffer. Tests: - sbt "remote / Test / testOnly org.apache.pekko.remote.artery.SystemMessageDeliverySpec" — all 9 tests pass References: Fixes #3174, Refs #3160 Report URL: https://github.com/apache/pekko/actions/runs/28138655502 With regards, GitHub Actions via GitBox --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
