pjfanning commented on code in PR #3188:
URL: https://github.com/apache/pekko/pull/3188#discussion_r3477528481


##########
persistence-typed/src/test/java/jdocs/org/apache/pekko/persistence/typed/MovieWatchList.java:
##########
@@ -71,7 +70,7 @@ public MovieWatchList(PersistenceId persistenceId) {
 
   @Override
   public MovieList emptyState() {
-    return new MovieList(Collections.emptySet());
+    return new MovieList(Set.of());

Review Comment:
   I prefer .emptySet(), .emptyMap() because they use an immutable singleton as 
opposed to creating a new empty set, map, etc



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to