The GitHub Actions job "Generate doc check" on pekko.git/fix-tcp-unregistered-channel-close has succeeded. Run started by GitHub user goutamadwant (triggered by He-Pin).
Head commit for run: 97cdfdf6372469bb5aa6cfb9b899a1f408d6a577 / goutamadwant <[email protected]> Close unregistered TCP channels on setup failure #3246 Motivation: Outgoing TCP connection setup can fail before the connection actor receives a ChannelRegistration. In that path the SocketChannel remained open after CommandFailed was reported. Modification: Close still-open channels directly from postStop when no ChannelRegistration exists. Keep the existing registered-channel cancelAndClose path unchanged. Extend the setup-failure integration test to verify the socket is closed. Result: Setup failures before ChannelRegistration no longer leave the SocketChannel open. Tests: - sbt "actor-tests / Test / testOnly org.apache.pekko.io.TcpIntegrationSpec" - sbt "actor / Compile / scalafmtCheck" "actor-tests / Test / scalafmtCheck" - git diff --check References: Fixes #3246 Report URL: https://github.com/apache/pekko/actions/runs/28424529257 With regards, GitHub Actions via GitBox --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
