jrudolph commented on PR #1132: URL: https://github.com/apache/pekko-http/pull/1132#issuecomment-4892483081
As long as there's no clear performance win (which is already arguably irrelevant for tests), I'd keep the simpler existing versions. In general, a change like that *can* help in hot loops or wherever inlining can help with further optimizations but in many cases, there are other inlining hazards so that there's no real benefit of complicating the code for that. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
