pjfanning commented on code in PR #557:
URL:
https://github.com/apache/pekko-persistence-jdbc/pull/557#discussion_r3531073190
##########
core/src/main/scala/org/apache/pekko/persistence/jdbc/util/PluginVersionChecker.scala:
##########
@@ -14,17 +14,19 @@
package org.apache.pekko.persistence.jdbc.util
+import java.lang.invoke.MethodHandles
+
import org.apache.pekko.annotation.InternalApi
@InternalApi
private[jdbc] object PluginVersionChecker {
def check(): Unit =
try {
-
Class.forName("org.apache.pekko.persistence.jdbc.util.DefaultSlickDatabaseProvider")
+
MethodHandles.lookup().findClass("org.apache.pekko.persistence.jdbc.util.DefaultSlickDatabaseProvider")
throw new RuntimeException(
"Old version of Apache Pekko Persistence JDBC found on the classpath.
Remove `com.github.dnvriend:pekko-persistence-jdbc` from the classpath..")
Review Comment:
this check is nonsense - an old akka check that was accidentally kept in
pekko but modified to make no sense along the way -
com.github.dnvriend:pekko-persistence-jdbc never existed
com.github.dnvriend:akka-persistence-jdbc is a thing but it won't interfere
with pekko-persistence-jdbc
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
