pjfanning commented on code in PR #3030: URL: https://github.com/apache/pekko/pull/3030#discussion_r3557845882
########## stream/src/main/scala/org/apache/pekko/stream/impl/fusing/GraphInterpreter.scala: ########## @@ -13,6 +13,7 @@ package org.apache.pekko.stream.impl.fusing +import java.util.BitSet Review Comment: I'm struggling to review this PR. I much prefer when coders commit review changes separately and don't keep squashing the code. We squash it when we merge anyway. We lose all the history of the review when the the coder forces a new squashed commit. It is sometimes useful when there are lots of commits to squash some or all of the commits but generally, it is easier for reviewers if this does not happen. So in short, I don't know what this PR looked like before the BitSet was introduced. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
