He-Pin opened a new pull request, #3321:
URL: https://github.com/apache/pekko/pull/3321

   ### Motivation
   
   The `TcpConnectionSpec` pull-mode test assumed data written on the server 
side was immediately readable by the client. Under load, `ResumeReading` could 
perform a non-blocking read before the data arrived; it then registered 
`OP_READ`, but the test uses a probe as the connection selector and never 
delivered the later `ChannelReadable` notification.
   
   ### Modification
   
   Assert that each payload is written in full and use the test NIO selector to 
wait until the client channel is readable before each `ResumeReading` command.
   
   ### Result
   
   The test still verifies that pull mode emits exactly one `Tcp.Received` per 
pull while no longer depending on loopback delivery timing.
   
   ### Tests
   
   - JDK 25 focused pull-mode test, 10 consecutive runs: passed
   - JDK 25 full `TcpConnectionSpec`: 35 passed, 0 failed (1 ignored, 1 pending)
   - `sbt headerCreateAll +headerCheckAll checkCodeStyle`: passed
   - `scalafmt --list --mode diff-ref=origin/main`: passed
   - `git diff --check`: passed
   - Qoder stdout review: no must-fix findings
   
   ### References
   
   Fixes #3311


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to