The GitHub Actions job "Pull Requests" on pekko.git/fix/partition-hub-poststop 
has succeeded.
Run started by GitHub user He-Pin (triggered by He-Pin).

Head commit for run:
081f120b265397c0c25794d12836d5a52645b420 / 虎鸣 <[email protected]>
fix(stream): notify PartitionHub consumers on materializer shutdown

Motivation:
When the materializer running a PartitionHub.sink is shut down (e.g. the
hosting actor stops or crashes), consumers materialized on a different
materializer may not be notified of the hub's termination. This mirrors
the same bug pattern found in BroadcastHub (see #3345).

Modification:
Move registered-consumer notification from onUpstreamFailure to postStop
so that postStop is the single notification point for all consumers.
postStop now handles both Open (normal termination) and Closed (after
upstream failure) states, ensuring registered consumers always receive
the appropriate signal. Each callback invocation is wrapped in
try/catch NonFatal so a single consumer failure does not short-circuit
the notification loop.

Result:
PartitionHub consumers are reliably notified when the hub's materializer
shuts down, preventing consumers from hanging indefinitely.

Tests:
- sbt "stream-tests / Test / testOnly org.apache.pekko.stream.scaladsl.HubSpec"

References:
Refs #3345

Report URL: https://github.com/apache/pekko/actions/runs/29412337643

With regards,
GitHub Actions via GitBox


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to