He-Pin opened a new pull request, #3357:
URL: https://github.com/apache/pekko/pull/3357

   ### Motivation
   
   Typed actor logging documents `sourceThread` as an MDC attribute, but 
`ActorMdc.setMdc` did not populate it. This made typed actor log entries 
inconsistent with classic actors and prevented correlation with the dispatcher 
thread.
   
   ### Modification
   
   - Add the `sourceThread` MDC entry using the current dispatcher thread name.
   - Add a regression test that verifies the MDC value matches the logging 
event thread.
   - Update the existing typed MDC whitelist assertion for the documented key.
   
   ### Result
   
   Typed actor log entries now include the documented `sourceThread` MDC value, 
consistent with classic actor logging.
   
   ### Tests
   
   - Regression proof without the production `MDC.put`: focused `sourceThread` 
test failed as expected because the MDC key was absent.
   - `sbt "actor-typed-tests / Test / testOnly 
org.apache.pekko.actor.typed.scaladsl.ActorLoggingSpec"` — 20 passed.
   - `sbt "headerCreateAll" "+headerCheckAll" "checkCodeStyle"` — passed.
   - `sbt "+mimaReportBinaryIssues"` — passed for Scala 2.13.18 and 3.3.8.
   - `scalafmt --list --mode diff-ref=origin/main` — passed with no changed 
files reported.
   - `git diff --check origin/main...HEAD` — passed.
   - `sbt validatePullRequest` — attempted; the changed typed logging suite and 
affected actor suites passed, but the aggregate task failed on unrelated 
local/baseline cases: a JDK 25 JFR method-signature mismatch in 
cluster-sharding Multi-JVM, unavailable LevelDB JNI on macOS ARM in 
persistence-typed, and the existing `pekko.dispatch.UnboundedMailbox` class 
name in `jdocs.stream.IntegrationDocTest`.
   
   ### References
   
   Fixes #3239
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to