He-Pin opened a new pull request, #3364: URL: https://github.com/apache/pekko/pull/3364
### Motivation `ClusterRouterPool` inherited the generic positive `AdjustPoolSize` handling, which always created local routees. This could bypass eligible-node filtering, role and `allow-local-routees` settings, `max-total-nr-of-instances`, and `max-nr-of-instances-per-node`. ### Modification Route positive `AdjustPoolSize` changes through the existing cluster deployment selector, while limiting additions to the requested delta. Keep zero and negative adjustments on the existing generic path. Add directional tests for node eligibility, total and per-node limits, and exact requested growth, and document the constrained behavior. ### Result Pool-size increases add as many routees as requested and eligible capacity allows, without bypassing cluster router deployment constraints. ### Tests - `sbt "cluster / Test / testOnly org.apache.pekko.cluster.routing.ClusterRouterSupervisorSpec"` — passed, 6 tests; also passed 5 consecutive runs with dispatcher throughput 1 - `sbt "cluster / Test / test"` — passed, 370 tests - `sbt "docs / paradox"` — passed - `sbt "+headerCheckAll" checkCodeStyle` — passed - `sbt "+mimaReportBinaryIssues"` — passed for Scala 2 and Scala 3 - `scalafmt --list --mode diff-ref=origin/main` — passed - `git diff --check origin/main` — passed - `sbt validatePullRequest` — ran for 55 minutes and passed affected Cluster and downstream suites, then failed in `docs / Pr-validation / test`: 634 passed and the existing `jdocs.stream.IntegrationDocTest` failed because `IntegrationDocTest.java:68` references the nonexistent `pekko.dispatch.UnboundedMailbox`; a focused rerun reproduced it and this PR does not change that file - `sbt sortImports` — not completed because the existing SortImports tooling throws `NoSuchMethodError: scala.meta.package$.Input()`; its unrelated partial edits were discarded, and changed imports pass scalafmt and compilation ### References Fixes #3362 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
