pjfanning commented on code in PR #3332:
URL: https://github.com/apache/pekko/pull/3332#discussion_r3609370604
##########
actor/src/main/scala/org/apache/pekko/actor/dungeon/ReceiveTimeout.scala:
##########
@@ -19,10 +19,16 @@ import scala.concurrent.duration.FiniteDuration
import org.apache.pekko
import pekko.actor.ActorCell
import pekko.actor.Cancellable
+import pekko.actor.Identify
import pekko.actor.NotInfluenceReceiveTimeout
private[pekko] object ReceiveTimeout {
final val emptyReceiveTimeoutData: (Duration, Cancellable) =
(Duration.Undefined, ActorCell.emptyCancellable)
+
+ // Identify is also an AutoReceivedMessage. Checking its concrete class
first avoids polluting its secondary
+ // supertype cache on JDKs affected by JDK-8180450 when actor runtime code
also checks the AutoReceivedMessage marker.
+ @inline def isNotInfluenceReceiveTimeout(message: Any): Boolean =
Review Comment:
`@inline` doesn't work for Scala 3. You might need to create a Scala 2 and
Scala 3 file with just this method. Better than copy/pasting this whole scala
file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]