mkurz commented on code in PR #1114:
URL: https://github.com/apache/pekko-http/pull/1114#discussion_r3639593629
##########
http-core/src/main/scala/org/apache/pekko/http/scaladsl/model/ws/WebSocketUpgrade.scala:
##########
@@ -81,13 +121,34 @@ trait WebSocketUpgrade extends jm.ws.WebSocketUpgrade {
def handleMessagesWith(handlerFlow: Graph[FlowShape[jm.ws.Message,
jm.ws.Message], ? <: Any]): HttpResponse =
handleMessages(JavaMapping.toScala(handlerFlow))
+ /**
+ * Java API
+ *
+ * @since 2.0.0
+ */
+ def handleMessagesWith(
+ handlerFlow: Graph[FlowShape[jm.ws.Message, jm.ws.Message], ? <: Any],
+ compressionEnabled: Boolean): HttpResponse =
+ handleMessages(JavaMapping.toScala(handlerFlow), None, compressionEnabled)
+
/**
* Java API
*/
def handleMessagesWith(
handlerFlow: Graph[FlowShape[jm.ws.Message, jm.ws.Message], ? <: Any],
subprotocol: String): HttpResponse =
handleMessages(JavaMapping.toScala(handlerFlow), subprotocol =
Some(subprotocol))
+ /**
+ * Java API
+ *
+ * @since 2.0.0
+ */
+ def handleMessagesWith(
Review Comment:
The complete method documentation is present on
`org.apache.pekko.http.javadsl.model.ws.WebSocketUpgrade`. The corresponding
methods in the Scala DSL trait are bridge implementations of that Java API and
follow the existing convention of using the Java API marker. The new public
methods also have `@since 2.0.0`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
