pjfanning commented on code in PR #3378: URL: https://github.com/apache/pekko/pull/3378#discussion_r3650282883
########## actor/src/main/mima-filters/2.0.x.backwards.excludes/replace-tuple2-with-pair.excludes: ########## @@ -0,0 +1,5 @@ +# Replace scala.Tuple2 with pekko.japi.Pair in FSMTransitionHandlerBuilder +# https://github.com/apache/pekko/issues/2086 +ProblemFilters.exclude[IncompatibleResultTypeProblem]("org.apache.pekko.japi.pf.FSMTransitionHandlerBuilder.build") +ProblemFilters.exclude[IncompatibleSignatureProblem]("org.apache.pekko.japi.pf.FSMTransitionHandlerBuilder.build") +ProblemFilters.exclude[IncompatibleMethTypeProblem]("org.apache.pekko.japi.pf.FSMTransitionHandlerBuilder.state") Review Comment: can you list this PR in the migration notes because it is a breaking change https://github.com/apache/pekko/blob/main/docs/src/main/paradox/migration/migration-guide-1.x-2.x.md -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
