The GitHub Actions job "Nightly Builds (1.7)" on pekko.git/main has failed. Run started by GitHub user pjfanning (triggered by pjfanning).
Head commit for run: 2214215b7b44c631de4e4031f04be6be165f1d8f / He-Pin(kerr) <[email protected]> Mark public sealed traits and abstract classes with @DoNotInherit (#3386) * feat: mark public sealed traits and abstract classes with @DoNotInherit Motivation: Java users can extend sealed traits and sealed abstract classes since Java has no sealed keyword. These types are designed under a closed-world assumption and should not be extended by user code. Modification: Add @DoNotInherit annotation to ~110 public sealed types across actor, actor-typed, stream, cluster, cluster-tools, cluster-sharding, cluster-sharding-typed, cluster-metrics, cluster-typed, distributed-data, persistence, persistence-typed, persistence-tck, persistence-testkit, testkit, and stream-testkit modules. Result: Java users are clearly signaled that these types are not for extension, and MiMa can safely allow adding methods to these interfaces in future releases without breaking binary compatibility. Tests: - sbt actor/compile actor-typed/compile stream/compile cluster/compile - sbt cluster-tools/compile cluster-sharding/compile cluster-sharding-typed/compile - sbt cluster-metrics/compile distributed-data/compile cluster-typed/compile - sbt persistence/compile persistence-typed/compile testkit/compile - sbt stream-testkit/compile persistence-testkit/compile persistence-tck/compile - sbt actor/mimaReportBinaryIssues stream/mimaReportBinaryIssues cluster/mimaReportBinaryIssues - All compilation and MiMa checks pass References: Fixes #1270 * fix: adversarial review corrections for @DoNotInherit annotations Motivation: Adversarial review found over-additions and missed types. Modification: - Remove @DoNotInherit from CapabilityFlags (root of TCK extension hierarchy, sub-traits are non-sealed and user-facing) - Add missed @DoNotInherit to: Dns.Command, LineNumbers.Result, Effect.ReceiveTimeoutCancelled, Effect.NoEffects, Effect.TimerScheduled.TimerMode, FishingOutcome.ContinueOutcome, Attributes.CancellationStrategy.Strategy, ConnectionSnapshot.ConnectionState Result: Annotations are now precisely scoped to types truly designed under closed-world assumption where users should not extend them. Tests: - sbt actor/compile actor-testkit-typed/compile stream/compile persistence-tck/compile — success References: Refs #1270 Report URL: https://github.com/apache/pekko/actions/runs/30228501915 With regards, GitHub Actions via GitBox --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
